Skip to content

Add Python wrapping for itk::PhasedArray3DSpecialCoordinatesImage#4099

Closed
dzenanz wants to merge 9 commits intoInsightSoftwareConsortium:masterfrom
dzenanz:master
Closed

Add Python wrapping for itk::PhasedArray3DSpecialCoordinatesImage#4099
dzenanz wants to merge 9 commits intoInsightSoftwareConsortium:masterfrom
dzenanz:master

Conversation

@dzenanz
Copy link
Member

@dzenanz dzenanz commented Jul 6, 2023

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5

@dzenanz dzenanz requested a review from tbirdso July 6, 2023 19:08
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module type:Data Changes to testing data labels Jul 6, 2023
@dzenanz dzenanz mentioned this pull request Jul 6, 2023
Closed
@dzenanz
Copy link
Member Author

dzenanz commented Jul 6, 2023

This has the following warnings:

115>------ Build started: Project: ITKCommonSwig, Configuration: RelWithDebInfo x64 ------
115>Run igenerator.py for ITKCommon
115>itkPhasedArray3DSpecialCoordinatesImageFilters: warning(4): ITK type not wrapped, or currently not known: itk::ImageIOBase
115>itkPhasedArray3DSpecialCoordinatesImageFilters: warning(4): ITK type not wrapped, or currently not known: itk::DataObjectDecorator< itk::Transform< double, 3, 3 > >
115>itkPhasedArray3DSpecialCoordinatesImageFilters: warning(4): ITK type not wrapped, or currently not known: itk::Transform< double, 3, 3 >

I think they are due to Modules/Core/Common/wrapping/itkPhasedArray3DSpecialCoordinatesImageFilters.wrap needing to be broken up into pieces, and distributed throughout modules such as Transform, ImageGrid etc. As builds are quite slow, it will take me a while to do all this.

@github-actions github-actions bot added area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module labels Jul 6, 2023
dzenanz added 3 commits July 6, 2023 16:21
@dzenanz
WIP: Move the test to ImageGrid module
6fd65c3
@dzenanz
WIP: Distribute PA3DSCI wrappings throughout the library
361520c
@dzenanz
WIP: Add image2image for PA->regular
56b9c2b 
Meant to address:

15>------ Build started: Project: ITKImageFilterBaseSwig, Configuration: RelWithDebInfo x64 ------
15>Run igenerator.py for ITKImageFilterBase
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< short >, itk::Image< unsigned char, 3 > >
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< short >, itk::Image< float, 3 > >
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< unsigned char >, itk::Image< short, 3 > >
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< unsigned char >, itk::Image< float, 3 > >
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< float >, itk::Image< short, 3 > >
15>itkCastImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::ImageToImageFilter< itk::PhasedArray3DSpecialCoordinatesImage< float >, itk::Image< unsigned char, 3 > >
dzenanz added 2 commits July 6, 2023 17:33
@dzenanz
WIP: Add wrapping for itk::InPlaceImageFilter
7c577ce 
Trying to fix:

359>Generating itkMeshIOBasePython.cpp, ../../Generators/Python/itk/itkMeshIOBasePython.py
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< short, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< short > >
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< short, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< unsigned char > >
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< unsigned char, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< short > >
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< unsigned char, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< unsigned char > >
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< float, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< short > >
349>itkRescaleIntensityImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::InPlaceImageFilter< itk::Image< float, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< unsigned char > >
@dzenanz
COMP: Fix include error
5530223 
C:/Dev/ITK-py11/Wrapping/castxml_inputs/itkInPlaceImageFilterB.cxx(253,107): error G60A5EC10: no member named 'PhasedArray3DSpecialCoordinatesImage' in namespace 'itk'
@dzenanz dzenanz mentioned this pull request Jul 7, 2023
Merged
4 tasks
@dzenanz
Copy link
Member Author

dzenanz commented Jul 7, 2023

Closing in favor of #4101.

@dzenanz dzenanz closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbirdso tbirdso Awaiting requested review from tbirdso

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Python wrapping Python bindings for a class type:Data Changes to testing data type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dzenanz